feat: inner products for mixed method - #3994
Open
chauj96 wants to merge 18 commits into
Open
Conversation
chauj96
changed the title
chauj96
added
ci: run CUDA builds
chauj96
changed the title
chauj96
marked this pull request as ready for review
March 16, 2026 23:36
bd713
approved these changes
Aug 4, 2026
bd713
left a comment
bd713
left a comment
Contributor
There was a problem hiding this comment.
Let's update the PR description to clearly explain that the change in centroid computation is the reason a rebaseline is needed.
OmarDuran
added
flag: requires rebaseline
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the implementation of$M$ used in the MFD mixed method formulation.
computeM, which computes the inner product matrixTPFAInnerProductBdVLMInnerProductQuasiTPFAInnerProductSimpleInnerProductEach class now includes a
computeMroutine that construct the inner product matrixTesting
Unit tests were added in
testMimeticInnerProductsto verify the correctness of the newly implementedcomputeMfunctions. All tests currently pass.The centroid computation has been updated to evaluate the exact volume of a polyhedron with planar polygonal facets. This property is verified by a unit test. This induces a rebaseline.
+) Minor variable naming updates were applied in
SimpleInnerProductto keep the geometry nomenclature consistent with the other inner product implemenations.